Test the three bugs that reached the living room, and script the release
The rate limit, the version compare and the download check were all wrapped in Android — a Context, a socket, a file — so none of them had a test, and all three shipped broken: the remote thrown out after five reconnects (0.11.1), a truncated APK handed to the installer (0.11.5), and a version compare that would read 0.11.10 as older than 0.11.9 the moment we get there. They are now plain Kotlin in AttemptBudget and UpdateRules, with the clock injected, and 20 tests covering the failures themselves. AttemptBudget also prunes expired entries before evicting: dropping only empty queues let the map grow without bound while every tracked address held one fresh failure. tests/smoke.sh installs the debug APK on the headless emulator, walks the first screen with the D-pad and fails on a crash or ANR — the class of bug unit tests cannot see, and the reason 0.11.0 crashed on startup. Forty seconds end to end. tools/release.sh does the bump, tests, signed build, tag, apk branch and Gitea release in one command. It refuses an unsigned build and never writes the release notes itself; commit subjects are offered as a draft. tests/helpers/jdk.sh picks a JDK Gradle can run on: Ubuntu moved default-java to 25, which fails the build with a bare "IllegalArgumentException: 25.0.4". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
be-nj
38
tests/helpers/jdk.sh
Executable file
38
tests/helpers/jdk.sh
Executable file
@@ -0,0 +1,38 @@
|
||||
#!/usr/bin/env bash
|
||||
# Picks a JDK that Gradle can actually run on and exports JAVA_HOME.
|
||||
#
|
||||
# Ubuntu moved default-java to 25, which the Gradle version in this repo
|
||||
# refuses with a bare "IllegalArgumentException: 25.0.4" — an unhelpful
|
||||
# message for a build that worked yesterday. Sourced by the scripts under
|
||||
# tests/ and tools/; harmless when JAVA_HOME is already a supported JDK.
|
||||
#
|
||||
# . tests/helpers/jdk.sh
|
||||
set -u
|
||||
|
||||
_jdk_major() {
|
||||
"$1/bin/java" -version 2>&1 | head -1 |
|
||||
sed -E 's/.*version "([0-9]+).*/\1/'
|
||||
}
|
||||
|
||||
_jdk_pick() {
|
||||
local candidate major
|
||||
if [ -n "${JAVA_HOME:-}" ] && [ -x "${JAVA_HOME}/bin/java" ]; then
|
||||
major="$(_jdk_major "$JAVA_HOME")"
|
||||
if [ "$major" -ge 17 ] 2>/dev/null && [ "$major" -le 21 ] 2>/dev/null; then
|
||||
return 0
|
||||
fi
|
||||
fi
|
||||
for candidate in \
|
||||
/usr/lib/jvm/java-21-openjdk-amd64 \
|
||||
/usr/lib/jvm/java-17-openjdk-amd64 \
|
||||
"$HOME"/jdk-21* \
|
||||
"$HOME"/jdk-17*; do
|
||||
[ -x "$candidate/bin/java" ] || continue
|
||||
export JAVA_HOME="$candidate"
|
||||
return 0
|
||||
done
|
||||
echo "no JDK 17-21 found; Gradle cannot run on $(java -version 2>&1 | head -1)" >&2
|
||||
return 1
|
||||
}
|
||||
|
||||
_jdk_pick
|
||||
115
tests/smoke.sh
Executable file
115
tests/smoke.sh
Executable file
@@ -0,0 +1,115 @@
|
||||
#!/usr/bin/env bash
|
||||
# Smoke test on the headless Google TV emulator.
|
||||
#
|
||||
# Builds the debug APK, installs it, walks the first screen with the D-pad
|
||||
# and fails on anything the unit tests cannot see: a crash on startup, a
|
||||
# crash while navigating, an ANR. The 0.11.0 startup crash and the rail
|
||||
# crash on "Verein hinzufügen" would both have been caught here.
|
||||
#
|
||||
# tests/smoke.sh # build, run, leave the emulator up
|
||||
# tests/smoke.sh --apk <path> # skip the build, test this APK
|
||||
# tests/smoke.sh --stop # stop the emulator when done
|
||||
set -euo pipefail
|
||||
|
||||
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
|
||||
HELPERS="$ROOT/tests/helpers"
|
||||
RUNS="$ROOT/tests/runs"
|
||||
SERIAL="${CASTARR_SERIAL:-emulator-5554}"
|
||||
ADB="${ANDROID_SDK_ROOT:-$HOME/Android/Sdk}/platform-tools/adb"
|
||||
PKG="dev.castarr.tv"
|
||||
ACTIVITY="$PKG/.MainActivity"
|
||||
|
||||
APK=""
|
||||
STOP_AFTER=0
|
||||
while [ $# -gt 0 ]; do
|
||||
case "$1" in
|
||||
--apk) APK="$2"; shift 2 ;;
|
||||
--stop) STOP_AFTER=1; shift ;;
|
||||
*) echo "usage: $0 [--apk <path>] [--stop]" >&2; exit 2 ;;
|
||||
esac
|
||||
done
|
||||
|
||||
mkdir -p "$RUNS/screenshots"
|
||||
LOG="$RUNS/smoke.log"
|
||||
: > "$LOG"
|
||||
|
||||
step() { printf '\n== %s\n' "$1" | tee -a "$LOG"; }
|
||||
fail() { printf '\nFAIL: %s\n' "$1" | tee -a "$LOG" >&2; exit 1; }
|
||||
|
||||
if [ -z "$APK" ]; then
|
||||
step "Debug-APK bauen"
|
||||
# shellcheck source=tests/helpers/jdk.sh
|
||||
. "$HELPERS/jdk.sh"
|
||||
(cd "$ROOT" && ./gradlew assembleDebug --no-daemon -q) >>"$LOG" 2>&1 ||
|
||||
fail "Build fehlgeschlagen, siehe $LOG"
|
||||
APK="$ROOT/app/build/outputs/apk/debug/app-debug.apk"
|
||||
fi
|
||||
[ -f "$APK" ] || fail "APK nicht gefunden: $APK"
|
||||
|
||||
step "Emulator starten"
|
||||
"$HELPERS/emulator.sh" start | tee -a "$LOG"
|
||||
|
||||
step "Installieren"
|
||||
# A debug build over a signed release needs the old one gone first.
|
||||
"$ADB" -s "$SERIAL" uninstall "$PKG" >/dev/null 2>&1 || true
|
||||
"$ADB" -s "$SERIAL" install -r "$APK" >>"$LOG" 2>&1 || fail "Installation fehlgeschlagen"
|
||||
|
||||
step "Starten"
|
||||
"$ADB" -s "$SERIAL" logcat -c
|
||||
"$ADB" -s "$SERIAL" shell am start -W -n "$ACTIVITY" >>"$LOG" 2>&1 ||
|
||||
fail "am start fehlgeschlagen"
|
||||
|
||||
# The first frame is not the point — the crash usually lands a moment later,
|
||||
# when state loads.
|
||||
sleep 6
|
||||
|
||||
running() { [ -n "$("$ADB" -s "$SERIAL" shell pidof "$PKG" | tr -d '\r')" ]; }
|
||||
crashed() {
|
||||
"$ADB" -s "$SERIAL" logcat -d -b crash,main 2>/dev/null |
|
||||
grep -E "FATAL EXCEPTION|ANR in $PKG|Process $PKG .* has died" | head -20
|
||||
}
|
||||
|
||||
check() {
|
||||
local where="$1" trace
|
||||
trace="$(crashed || true)"
|
||||
if [ -n "$trace" ]; then
|
||||
printf '%s\n' "$trace" >>"$LOG"
|
||||
printf '%s\n' "$trace" | head -5
|
||||
fail "Absturz $where — vollständig in $LOG"
|
||||
fi
|
||||
running || fail "Prozess weg $where (kein Stacktrace im Log)"
|
||||
}
|
||||
|
||||
check "beim Start"
|
||||
"$HELPERS/emulator.sh" shot smoke-start >/dev/null
|
||||
|
||||
step "D-Pad-Navigation"
|
||||
# Down/right walks the rail and opens whatever has focus; back returns.
|
||||
for key in DPAD_DOWN DPAD_RIGHT DPAD_RIGHT DPAD_DOWN DPAD_CENTER BACK DPAD_UP; do
|
||||
"$ADB" -s "$SERIAL" shell input keyevent "$key"
|
||||
sleep 1
|
||||
done
|
||||
sleep 2
|
||||
check "bei der Navigation"
|
||||
"$HELPERS/emulator.sh" shot smoke-nav >/dev/null
|
||||
|
||||
step "Einstellungen öffnen"
|
||||
"$ADB" -s "$SERIAL" shell am start -n "$ACTIVITY" >/dev/null 2>&1
|
||||
sleep 2
|
||||
check "nach dem Wiedereintritt"
|
||||
|
||||
if [ "$STOP_AFTER" = 1 ]; then
|
||||
step "Emulator stoppen"
|
||||
"$HELPERS/emulator.sh" stop | tee -a "$LOG"
|
||||
fi
|
||||
|
||||
cat <<EOF
|
||||
|
||||
OK — kein Absturz, App läuft.
|
||||
Screenshots: $RUNS/screenshots/smoke-start.png, smoke-nav.png
|
||||
Log: $LOG
|
||||
|
||||
Der Test deckt Start, D-Pad und Wiedereintritt ab. Alles hinter dem
|
||||
Onboarding (echte Quelle, Wiedergabe, Kopplung) braucht ein Backend und
|
||||
bleibt Handarbeit.
|
||||
EOF
|
||||
101
tests/unit/AttemptBudgetTest.kt
Normal file
101
tests/unit/AttemptBudgetTest.kt
Normal file
@@ -0,0 +1,101 @@
|
||||
package dev.castarr.tv.server
|
||||
|
||||
import org.junit.Assert.assertEquals
|
||||
import org.junit.Assert.assertFalse
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Test
|
||||
|
||||
class AttemptBudgetTest {
|
||||
|
||||
private var clock = 0L
|
||||
private fun budget(
|
||||
windowMs: Long = 60_000L,
|
||||
maxFailures: Int = 5,
|
||||
maxTracked: Int = 64,
|
||||
) = AttemptBudget(windowMs, maxFailures, maxTracked) { clock }
|
||||
|
||||
/**
|
||||
* The 0.11.0 bug: the remote reconnects on every network hiccup, and
|
||||
* counting those successful handshakes threw the phone out after five.
|
||||
*/
|
||||
@Test
|
||||
fun `successful connections never cost budget`() {
|
||||
val budget = budget()
|
||||
repeat(50) {
|
||||
assertTrue(budget.allows("10.0.0.5"))
|
||||
budget.clear("10.0.0.5")
|
||||
}
|
||||
assertTrue(budget.allows("10.0.0.5"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `five failures in the window lock the address out`() {
|
||||
val budget = budget()
|
||||
repeat(5) {
|
||||
assertTrue(budget.allows("10.0.0.5"))
|
||||
budget.recordFailure("10.0.0.5")
|
||||
}
|
||||
assertFalse(budget.allows("10.0.0.5"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `a success after failures wipes the slate`() {
|
||||
val budget = budget()
|
||||
repeat(4) { budget.recordFailure("10.0.0.5") }
|
||||
budget.clear("10.0.0.5")
|
||||
repeat(4) {
|
||||
assertTrue(budget.allows("10.0.0.5"))
|
||||
budget.recordFailure("10.0.0.5")
|
||||
}
|
||||
assertTrue(budget.allows("10.0.0.5"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `failures expire once the window has passed`() {
|
||||
val budget = budget()
|
||||
repeat(5) { budget.recordFailure("10.0.0.5") }
|
||||
assertFalse(budget.allows("10.0.0.5"))
|
||||
clock += 60_001
|
||||
assertTrue(budget.allows("10.0.0.5"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `the window slides, it does not reset in blocks`() {
|
||||
val budget = budget()
|
||||
repeat(4) {
|
||||
budget.recordFailure("10.0.0.5")
|
||||
clock += 20_000
|
||||
}
|
||||
// Two of the four are older than a minute by now, so there is room.
|
||||
assertTrue(budget.allows("10.0.0.5"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `one address cannot spend another's budget`() {
|
||||
val budget = budget()
|
||||
repeat(5) { budget.recordFailure("10.0.0.9") }
|
||||
assertFalse(budget.allows("10.0.0.9"))
|
||||
assertTrue(budget.allows("10.0.0.5"))
|
||||
}
|
||||
|
||||
/** An attacker cycling source addresses must not grow the map forever. */
|
||||
@Test
|
||||
fun `tracked addresses stay bounded under a flood of fresh ones`() {
|
||||
val budget = budget(maxTracked = 8)
|
||||
repeat(500) { i ->
|
||||
budget.recordFailure("10.0.0.$i")
|
||||
clock += 10
|
||||
}
|
||||
assertTrue(budget.trackedAddresses() <= 8)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `eviction drops the stale addresses, not the active one`() {
|
||||
val budget = budget(maxTracked = 4)
|
||||
repeat(4) { i -> budget.recordFailure("10.0.1.$i") }
|
||||
clock += 60_001
|
||||
repeat(5) { budget.recordFailure("10.0.0.5") }
|
||||
assertFalse(budget.allows("10.0.0.5"))
|
||||
assertEquals(1, budget.trackedAddresses())
|
||||
}
|
||||
}
|
||||
76
tests/unit/UpdateRulesTest.kt
Normal file
76
tests/unit/UpdateRulesTest.kt
Normal file
@@ -0,0 +1,76 @@
|
||||
package dev.castarr.tv.update
|
||||
|
||||
import org.junit.Assert.assertFalse
|
||||
import org.junit.Assert.assertTrue
|
||||
import org.junit.Test
|
||||
|
||||
class UpdateRulesTest {
|
||||
|
||||
@Test
|
||||
fun `a higher patch level is newer`() {
|
||||
assertTrue(UpdateRules.isNewer("0.11.5", "0.11.4"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `the same version is not newer`() {
|
||||
assertFalse(UpdateRules.isNewer("0.11.5", "0.11.5"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `an older release never offers itself as an update`() {
|
||||
assertFalse(UpdateRules.isNewer("0.11.4", "0.11.5"))
|
||||
}
|
||||
|
||||
/** Segments are numbers, not text — "10" beats "9". */
|
||||
@Test
|
||||
fun `double digit segments compare numerically`() {
|
||||
assertTrue(UpdateRules.isNewer("0.11.10", "0.11.9"))
|
||||
assertFalse(UpdateRules.isNewer("0.11.9", "0.11.10"))
|
||||
assertTrue(UpdateRules.isNewer("0.12.0", "0.9.99"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `a missing segment counts as zero`() {
|
||||
assertFalse(UpdateRules.isNewer("0.12", "0.12.0"))
|
||||
assertTrue(UpdateRules.isNewer("0.12.1", "0.12"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `a leading v on the tag makes no difference`() {
|
||||
assertTrue(UpdateRules.isNewer("v0.11.5", "0.11.4"))
|
||||
assertFalse(UpdateRules.isNewer("v0.11.4", "v0.11.4"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `garbage in a tag does not offer an update`() {
|
||||
assertFalse(UpdateRules.isNewer("", "0.11.5"))
|
||||
assertFalse(UpdateRules.isNewer("nightly", "0.11.5"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `a complete download passes`() {
|
||||
assertTrue(UpdateRules.isComplete(actualBytes = 6_515_429, announcedBytes = 6_515_429))
|
||||
}
|
||||
|
||||
/** The 0.11.5 bug: a truncated APK left the installer hanging. */
|
||||
@Test
|
||||
fun `a truncated download is rejected`() {
|
||||
assertFalse(UpdateRules.isComplete(actualBytes = 3_000_000, announcedBytes = 6_515_429))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `an empty download is rejected even when nothing was announced`() {
|
||||
assertFalse(UpdateRules.isComplete(actualBytes = 0, announcedBytes = -1))
|
||||
assertFalse(UpdateRules.isComplete(actualBytes = 0, announcedBytes = 0))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `an unannounced length cannot be checked, so any content passes`() {
|
||||
assertTrue(UpdateRules.isComplete(actualBytes = 6_515_429, announcedBytes = -1))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `more bytes than announced is rejected too`() {
|
||||
assertFalse(UpdateRules.isComplete(actualBytes = 7_000_000, announcedBytes = 6_515_429))
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user